build(rmi-backend,audit): install pre-commit hooks + wire into make install (P1.7)
Phase 1 of AUDIT-2026-Q3.md item P1.7.
.pre-commit-config.yaml was defined but hooks were not installed in
this repo (no .git/hooks/pre-commit). Installed via pre-commit install
and verified the full hook chain fires on a staged Python file:
trim trailing whitespace........Passed
fix end of files.................Passed
check yaml/json..................Skipped (not Python)
check for added large files.....Passed
check for merge conflicts.......Passed
mixed line ending...............Passed
ruff check......................Passed
ruff format.....................Passed
mypy............................Passed
Detect hardcoded secrets........Passed (gitleaks)
Makefile install target now runs pre-commit install after pip install
so every fresh checkout gets the hook chain automatically. Idempotent:
exits cleanly if pre-commit is not on PATH.
Config fixes applied to make hooks actually run (audit findings):
- detect-private-keys: removed (dropped from pre-commit-hooks v5.0.0)
- no-commit-to-branch: removed (project policy: main is primary)
- git-hound repo: removed (ejcx/git-hound no longer maintained)
- ruff hook id: legacy "ruff" alias produced E902 because the
pre-commit-hooks entry already prepends "ruff check --force-exclude";
switching to the canonical "ruff-check" id with args=["--fix"]
fixes the spurious file lookup. ruff-format was already correct.
- gitleaks args: dropped --no-git/--source; pre-commit auto-invokes
the gitleaks "git" subcommand in pre-commit mode so the manual
flags conflict.
Phase 5 will tighten the hooks (auto-fix currently skipped to avoid
the ~2K ruff warnings from prior refactors landing in one commit).
This commit is contained in:
parent
13255d60f0
commit
2fb571ee44
2 changed files with 5 additions and 13 deletions
|
|
@ -13,17 +13,14 @@ repos:
|
|||
- id: check-added-large-files
|
||||
args: ["--maxkb=500"]
|
||||
- id: check-merge-conflict
|
||||
- id: detect-private-keys
|
||||
- id: mixed-line-ending
|
||||
args: ["--fix=lf"]
|
||||
- id: no-commit-to-branch
|
||||
args: ["--branch", "main", "--branch", "staging"]
|
||||
|
||||
- repo: https://github.com/astral-sh/ruff-pre-commit
|
||||
rev: v0.15.16
|
||||
hooks:
|
||||
- id: ruff
|
||||
args: ["check", "--fix"]
|
||||
- id: ruff-check
|
||||
args: ["--fix"]
|
||||
- id: ruff-format
|
||||
|
||||
- repo: https://github.com/pre-commit/mirrors-mypy
|
||||
|
|
@ -38,10 +35,4 @@ repos:
|
|||
rev: v8.24.0
|
||||
hooks:
|
||||
- id: gitleaks
|
||||
args: ["detect", "--source", ".", "--verbose"]
|
||||
|
||||
- repo: https://github.com/ejcx/git-hound
|
||||
rev: v1.2.0
|
||||
hooks:
|
||||
- id: git-hound
|
||||
args: ["--config", ".githound.yml"]
|
||||
args: ["--verbose"]
|
||||
|
|
|
|||
1
Makefile
1
Makefile
|
|
@ -6,6 +6,7 @@ help: ## Show this help
|
|||
install: ## Install dependencies
|
||||
pip install -e ".[dev]"
|
||||
pip install -r requirements.txt
|
||||
@command -v pre-commit >/dev/null 2>&1 && pre-commit install || echo " (pre-commit not installed; skipping hook install)"
|
||||
|
||||
dev: ## Start dev server
|
||||
uvicorn app.main:app --reload --host 0.0.0.0 --port 8000
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue