refactor(exceptions): add ruff BLE001; convert 103 broad except Exception
Per CONVENTIONS.md Part 2 ("Never bare except") and CONVENTIONS.md
Part 7 (pre-commit hooks: ruff), blind `except Exception` is now a
lint failure. Pre-existing sites are marked `# noqa: BLE001` for
later manual review; new code must use specific exception types.
Changes:
- pyproject.toml: added "BLE" to ruff lint select. BLE001 is now enforced
- 103 of 166 `except Exception` sites were auto-converted to specific
types based on context (httpx, json, OSError, subprocess, etc.)
- 62 remaining sites marked with `# noqa: BLE001` for later review
(mostly generic try/except wrappers that legitimately need broad catch
for graceful degradation: e.g. compliance LLM fallback must catch
any error to preserve the regex result)
- 1 manual fix: reverted compliance.py LLM fallback to broad except
with explicit "must catch all errors" comment + noqa
- 2 files (commerce_sync.py, crm_sync.py) needed `import httpx` added
so the auto-converted exception references would resolve
- 5 source files (agency, monitor, pipelines, auth_connector,
llm_providers/registry) renamed "name" -> "<scope>_name" in
extra={...} dicts because "name" is a reserved LogRecord field
Test impact:
- 14 failing tests -> 1 (the SSE subprocess test is a sandbox limitation,
pre-existing and unrelated)
- New `test_ble_temp.py` verifies BLE001 catches new violations
Follow-up:
- Each `# noqa: BLE001` site should be reviewed and replaced with a
specific exception type where possible. The most common legitimate
broad-catch case is the LLM fallback path; everything else probably
can be narrowed.
This commit is contained in:
parent
117001006f
commit
0200bf3e16
50 changed files with 172 additions and 166 deletions
16
automator.py
16
automator.py
|
|
@ -74,7 +74,7 @@ class PryAutomator:
|
|||
await asyncio.sleep(SESSION_CLEANUP_INTERVAL)
|
||||
try:
|
||||
await self._cleanup_stale_sessions()
|
||||
except Exception:
|
||||
except Exception: # noqa: BLE001
|
||||
pass
|
||||
|
||||
async def _get_or_create_session(
|
||||
|
|
@ -114,7 +114,7 @@ class PryAutomator:
|
|||
with open(cookies_file) as f:
|
||||
cookies = json.load(f)
|
||||
await context.add_cookies(cookies)
|
||||
except Exception:
|
||||
except OSError:
|
||||
pass
|
||||
|
||||
self.sessions[sid] = session
|
||||
|
|
@ -257,7 +257,7 @@ class PryAutomator:
|
|||
cookies = await session.context.cookies()
|
||||
with open(session.cookies_file, "w") as f:
|
||||
json.dump(cookies, f)
|
||||
except Exception:
|
||||
except OSError:
|
||||
pass
|
||||
|
||||
return {
|
||||
|
|
@ -267,7 +267,7 @@ class PryAutomator:
|
|||
"final_title": await page.title(),
|
||||
}
|
||||
|
||||
except Exception as e:
|
||||
except OSError as e:
|
||||
return {
|
||||
"session_id": session.id,
|
||||
"steps": results,
|
||||
|
|
@ -282,7 +282,7 @@ class PryAutomator:
|
|||
if cookies:
|
||||
try:
|
||||
await session.context.add_cookies(cookies)
|
||||
except Exception:
|
||||
except Exception: # noqa: BLE001
|
||||
pass
|
||||
await session.page.goto(url, wait_until="networkidle")
|
||||
return session.id
|
||||
|
|
@ -293,12 +293,12 @@ class PryAutomator:
|
|||
session = self.sessions.pop(session_id)
|
||||
try:
|
||||
await session.browser.close()
|
||||
except Exception:
|
||||
except OSError:
|
||||
pass
|
||||
if os.path.exists(session.cookies_file):
|
||||
try:
|
||||
os.remove(session.cookies_file)
|
||||
except Exception:
|
||||
except OSError:
|
||||
pass
|
||||
|
||||
def list_sessions(self) -> list[dict]:
|
||||
|
|
@ -319,7 +319,7 @@ class PryAutomator:
|
|||
session = self.sessions.pop(sid)
|
||||
try:
|
||||
await session.browser.close()
|
||||
except Exception:
|
||||
except OSError:
|
||||
pass
|
||||
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue