refactor(exceptions): add ruff BLE001; convert 103 broad except Exception
Per CONVENTIONS.md Part 2 ("Never bare except") and CONVENTIONS.md
Part 7 (pre-commit hooks: ruff), blind `except Exception` is now a
lint failure. Pre-existing sites are marked `# noqa: BLE001` for
later manual review; new code must use specific exception types.
Changes:
- pyproject.toml: added "BLE" to ruff lint select. BLE001 is now enforced
- 103 of 166 `except Exception` sites were auto-converted to specific
types based on context (httpx, json, OSError, subprocess, etc.)
- 62 remaining sites marked with `# noqa: BLE001` for later review
(mostly generic try/except wrappers that legitimately need broad catch
for graceful degradation: e.g. compliance LLM fallback must catch
any error to preserve the regex result)
- 1 manual fix: reverted compliance.py LLM fallback to broad except
with explicit "must catch all errors" comment + noqa
- 2 files (commerce_sync.py, crm_sync.py) needed `import httpx` added
so the auto-converted exception references would resolve
- 5 source files (agency, monitor, pipelines, auth_connector,
llm_providers/registry) renamed "name" -> "<scope>_name" in
extra={...} dicts because "name" is a reserved LogRecord field
Test impact:
- 14 failing tests -> 1 (the SSE subprocess test is a sandbox limitation,
pre-existing and unrelated)
- New `test_ble_temp.py` verifies BLE001 catches new violations
Follow-up:
- Each `# noqa: BLE001` site should be reviewed and replaced with a
specific exception type where possible. The most common legitimate
broad-catch case is the LLM fallback path; everything else probably
can be narrowed.
This commit is contained in:
parent
117001006f
commit
0200bf3e16
50 changed files with 172 additions and 166 deletions
|
|
@ -103,7 +103,7 @@ async def _send_discord(
|
|||
if resp.is_success:
|
||||
return {"success": True, "channel": "discord"}
|
||||
return {"success": False, "error": f"Discord returned {resp.status_code}"}
|
||||
except Exception as e:
|
||||
except (httpx.HTTPError, httpx.RequestError) as e:
|
||||
return {"success": False, "error": str(e)[:200]}
|
||||
|
||||
|
||||
|
|
@ -131,7 +131,7 @@ async def _send_teams(
|
|||
if resp.is_success:
|
||||
return {"success": True, "channel": "teams"}
|
||||
return {"success": False, "error": f"Teams returned {resp.status_code}"}
|
||||
except Exception as e:
|
||||
except (httpx.HTTPError, httpx.RequestError) as e:
|
||||
return {"success": False, "error": str(e)[:200]}
|
||||
|
||||
|
||||
|
|
@ -156,7 +156,7 @@ async def _send_telegram(
|
|||
if resp.is_success:
|
||||
return {"success": True, "channel": "telegram"}
|
||||
return {"success": False, "error": f"Telegram returned {resp.status_code}"}
|
||||
except Exception as e:
|
||||
except (httpx.HTTPError, httpx.RequestError) as e:
|
||||
return {"success": False, "error": str(e)[:200]}
|
||||
|
||||
|
||||
|
|
@ -189,7 +189,7 @@ async def _send_sms(
|
|||
if resp.is_success:
|
||||
return {"success": True, "channel": "sms", "provider": "twilio"}
|
||||
return {"success": False, "error": f"Twilio error: {resp.text[:200]}"}
|
||||
except Exception as e:
|
||||
except Exception as e: # noqa: BLE001
|
||||
return {"success": False, "error": str(e)[:200]}
|
||||
|
||||
return {"success": False, "error": f"SMS provider '{provider}' not supported"}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue